[Task] VX-233 johnlin/resource createdby #204

John-Lin · 2018-07-30T09:26:33Z

No description provided.

codecov-io · 2018-07-30T10:17:35Z

Codecov Report

Merging #204 into develop will increase coverage by <.01%.
The diff coverage is 67.81%.

@@             Coverage Diff             @@
##           develop     #204      +/-   ##
===========================================
+ Coverage    78.57%   78.57%   +<.01%     
===========================================
  Files           59       60       +1     
  Lines         3300     3361      +61     
===========================================
+ Hits          2593     2641      +48     
- Misses         540      547       +7     
- Partials       167      173       +6

Impacted Files	Coverage Δ
src/networkprovider/ovs_system.go	`77.77% <ø> (+4.09%)`	⬆️
src/networkprovider/ovs_netdev.go	`64.7% <ø> (+2.44%)`	⬆️
src/server/backend/user.go	`0% <0%> (ø)`
src/server/backend/authenticate.go	`83.33% <100%> (ø)`	⬆️
src/server/backend/jwt.go	`100% <100%> (ø)`	⬆️
src/server/route.go	`84.67% <100%> (+0.51%)`	⬆️
src/server/handler_volume.go	`68.68% <62.5%> (-0.55%)`	⬇️
src/server/handler_network.go	`71.33% <66.66%> (-0.29%)`	⬇️
src/server/handler_service.go	`70.94% <66.66%> (-0.36%)`	⬇️
src/server/handler_pod.go	`69.16% <66.66%> (-0.21%)`	⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf50cfa...e2dbc66. Read the comment docs.

WakeupTsai · 2018-08-01T02:17:17Z

src/server/handler_network.go

+			return
+		}
+	}
+	network.CreatedBy = user


一般是不是都存ID之類的，需要存到整個entity嗎？

需要，這樣比較有效率不用再多打一次 user api

這樣如果user可以修改任何欄位的話，就會造成資訊不對等

同時若有user被刪除，你從這邊不能知道他被刪除

我們大部分操作都不會很大量的需求所以這邊的mongo lookuuup 應該沒太大的效能問題

user 不能修改id. 這個有跟前端討論過，主要是前端 query 的方式，多打一次user前端邏輯變得複雜

WakeupTsai · 2018-08-01T02:27:08Z

src/server/handler_network_test.go

 	//init session
 	suite.session = sp.Mongo.NewSession()
 	//init restful container
 	suite.wc = restful.NewContainer()
 	service := newNetworkService(sp)
 	suite.wc.Add(service)

-	suite.sp = sp
+	token, _ := loginGetToken(suite.sp, suite.wc)
+	suite.JWTBearer = "Bearer " + token


空一格是故意的嗎？

這是他的header規則

Authorization: Bearer <token>

WakeupTsai · 2018-08-01T02:38:48Z

src/server/main_test.go

+	if v == 0 && failedDropTestDatabase() {
+		os.Exit(1)
+	}
+	os.Exit(v)


沒有處理v!=0時的db drop

我後來想一下 failedDropTestDatabase 都會跑到即使是 v!=0

真怪，按照 short circult最佳化，應該前面false, 後面就不會跑了?

另外，如果testing都如預料以及預期，成功跑完不需要清空 mongo.因為 testing本身就要清除乾淨

John-Lin · 2018-08-22T17:27:44Z

using $lookup to aggregate data

for example

db.users.insert({"_id":1,"username":"john"})
db.users.insert({"_id":2,"username":"john2"})
db.users.insert({"_id":3,"username":"yoyo"})
db.users.insert({"_id":4,"username":"yoyo2"})


db.networks.insert({"_id":1,"uid":3,"networkName":"yoyo-net"})
db.networks.insert({"_id":2,"uid":2,"networkName":"john-net2"})
db.networks.insert({"_id":3,"uid":1,"networkName":"john-net"})
db.networks.insert({"_id":4,"uid":4,"networkName":"yoyo-net2"})


db.networks.aggregate([
    {
      $lookup:
        {
          from: "users",
          localField: "uid",
          foreignField: "_id",
          as: "users_docs"
        }
   }
])


db.networks.aggregate([
    {
      $lookup:
        {
          from: "users",
          localField: "uid",
          foreignField: "_id",
          as: "users_docs"
        }
   },
   { $match : { _id : 3 } }
])

John-Lin · 2018-08-23T08:54:47Z

還剩下 deployment, app, namespace, storage, user 尚未做auth

John-Lin changed the title ~~[task] VX-233 johnlin/resource createdby~~ [Task] VX-233 johnlin/resource createdby Jul 30, 2018

John-Lin force-pushed the johnlin/resource-createdby branch 3 times, most recently from 39237b1 to 2ac5683 Compare July 31, 2018 07:38

WakeupTsai reviewed Aug 1, 2018

View reviewed changes

John-Lin force-pushed the johnlin/resource-createdby branch 4 times, most recently from 01beba8 to a7fc589 Compare August 7, 2018 03:31

John-Lin force-pushed the johnlin/resource-createdby branch from a7fc589 to 0d277c7 Compare August 8, 2018 12:25

John-Lin added the pending label Aug 9, 2018

John-Lin force-pushed the johnlin/resource-createdby branch 2 times, most recently from 14f3b1a to 3bfe35e Compare August 17, 2018 03:04

John-Lin force-pushed the johnlin/resource-createdby branch 4 times, most recently from 57f09d0 to fe3b024 Compare August 22, 2018 10:11

John-Lin force-pushed the johnlin/resource-createdby branch from 58a4825 to 1b5dca1 Compare August 23, 2018 08:43

John-Lin added 8 commits August 23, 2018 16:51

user bats tests

6eefbb1

add account/passwotd

a6bb958

add jwt auth

88491bb

add createdby field into network

6338561

insert user

7bc4f05

service has createdby field

785e828

fix 403

8f8b0ba

volume

f4b9073

John-Lin added 25 commits August 23, 2018 16:51

add cred

fdf20fe

fix test

3397433

fix test

fc02fd4

cleanup user data

8e0c92a

login when using delete

52e44cc

rename and comments

6258362

rename variable

c86b182

typos and doc

70232f1

fix test

f9cdd5c

fix test

ebf20b4

remove uuid and jwt

ee37b37

update doc

fba99d6

typos

9487f9f

add jwt auth httpie plugin

f2d0ea5

add test

9446a3e

remove uuid package

a613ac6

find and insert user when get/list/create

cbfc0aa

typos

5df9592

ignore finduser error

35d96fb

add ownerid

a5bb373

typos

b7ed738

ownerID

f1aa9c7

pod ownerID

a4cf87d

service owner id

84fc53d

volume ownerid

e2dbc66

John-Lin force-pushed the johnlin/resource-createdby branch from 1b5dca1 to e2dbc66 Compare August 23, 2018 08:52

John-Lin removed the pending label Aug 23, 2018

John-Lin merged commit c1139da into develop Aug 23, 2018

John-Lin deleted the johnlin/resource-createdby branch August 23, 2018 11:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Task] VX-233 johnlin/resource createdby #204

[Task] VX-233 johnlin/resource createdby #204

John-Lin commented Jul 30, 2018

codecov-io commented Jul 30, 2018 •

edited

Loading

WakeupTsai Aug 1, 2018

John-Lin Aug 1, 2018

hwchiu Aug 6, 2018

hwchiu Aug 6, 2018

hwchiu Aug 6, 2018

John-Lin Aug 8, 2018

WakeupTsai Aug 1, 2018

John-Lin Aug 1, 2018

WakeupTsai Aug 1, 2018

John-Lin Aug 2, 2018

hwchiu Aug 2, 2018

John-Lin commented Aug 22, 2018 •

edited

Loading

John-Lin commented Aug 23, 2018 •

edited

Loading

[Task] VX-233 johnlin/resource createdby #204

[Task] VX-233 johnlin/resource createdby #204

Conversation

John-Lin commented Jul 30, 2018

codecov-io commented Jul 30, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

John-Lin commented Aug 22, 2018 • edited Loading

John-Lin commented Aug 23, 2018 • edited Loading

codecov-io commented Jul 30, 2018 •

edited

Loading

John-Lin commented Aug 22, 2018 •

edited

Loading

John-Lin commented Aug 23, 2018 •

edited

Loading